induced_subgraph: new method based on a subset of edges #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package already has a method for an
induced_subgraph
based on a subset of nodes.While doing so, I noticed that
issubset
may have a bug, as an induced subgraph is not always a subset of the original graph. I added a sentence in the documentation warning users thatissubset
is not fully supported yet. The issue is not related to the new function: I added 2 examples, one of which is an induced subgraph from a subset of vertices.I also noticed that
issubset
checks the relationship between the underlying graphs only, so I added comments inside the function to note that there's no check on the 2 graphs having consistent vertex labels or edge data.I'm happy to remove everything about
issubset
from this PR. But then users following the package documentation may notice that the example induced subgraph is not a subset of its parent graph, and I wanted to be proactive about recognizing the issue.