Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fix CssProviderLeaf(filename="...") #204

Merged
merged 1 commit into from
Nov 30, 2015

Conversation

fcard
Copy link
Contributor

@fcard fcard commented Nov 29, 2015

There was an extra type in the c function signature.

@vtjnash
Copy link
Contributor

vtjnash commented Nov 29, 2015

the return type is wrong too -- should be Cint != 0, not Bool (also for gtk_css_provider_load_from_data)

https://developer.gnome.org/gtk3/stable/GtkCssProvider.html#gtk-css-provider-load-from-path

@vtjnash
Copy link
Contributor

vtjnash commented Nov 29, 2015

also, can I ask you to squash the commits into one commit?

@fcard
Copy link
Contributor Author

fcard commented Nov 29, 2015

I will, but for some reason the travis log keeps saying the css file is invalid (even through it works for me both on windows and linux), so I am trying to guess what the problem is and fix that first.

@fcard
Copy link
Contributor Author

fcard commented Nov 29, 2015

Yeah, I don't get it, for some reason travis is reading the css file differently. I am going to try to reproduce the travis environment here to debug this out, I will be back soon.

Meanwhile, CssProviderLeaf(data="...") locks my computer on windows, no clue about that one either.

There was an extra type in the c function signature.

fixes JuliaGraphics#203
@fcard
Copy link
Contributor Author

fcard commented Nov 29, 2015

Done! There was some problem with travis's gtk when parsing the font-size attribute.
@vtjnash, changing the return type caused a method error with !, so I am going to leave it as is for this PR, if you don't mind, to keep things simple.

vtjnash added a commit that referenced this pull request Nov 30, 2015
Fix CssProviderLeaf(filename="...")
@vtjnash vtjnash merged commit 81a6713 into JuliaGraphics:master Nov 30, 2015
@fcard fcard deleted the cssproviderfilename branch November 30, 2015 03:23
@hustf
Copy link

hustf commented Jan 5, 2016

A checkout (with this included) fixed:

(julia.exe:447752): GModule-CRITICAL **: g_module_symbol: assertion 'symbol != N
ULL' failed

which, I believe, appears when calling win = Gtk.@ Window("stuff", 800,600).

I believe this lead to unexpected behaviours in recent additions GTK utilities, Immerse and ProfileView as a window is actually opening and appears to work fine. This error message from GTK is already scrolled way up the screen when errors occur. So tag, please.

@hustf
Copy link

hustf commented Jan 5, 2016

Sorry, I was too quick there. The specific test case worked. I jumped into other modules and that may have changed some state. If I run Pkg.test("Gtk") on version 0.9.3+ I get:

julia> Pkg.test("Gtk")
INFO: Testing Gtk
.juliarc define function: lastfile()

(julia.exe:449068): GModule-CRITICAL **: g_module_symbol: assertion 'symbol != NULL' failed
**     repeated around 30 times    **
WARNING: Method definition g_type(Type{##9#T<:Gtk.GtkWidget}) in module Gtk at C:\Users\F\.julia\v0.4\Gtk\src\GLib\
gtype.jl:181 overwritten in module Test at C:\Users\F\.julia\v0.4\Gtk\src\GLib\gtype.jl:181.
The following messages:
   WARNING: Error in @guarded callback
are expected and a sign of normal operation.
WARNING: Error in @guarded callback
ERROR: UndefVarError: k not defined
WARNING: Error in @guarded callback
ERROR: UndefVarError: k not defined
WARNING: Error in @guarded callback
ERROR: UndefVarError: k not defined
WARNING: Error in @guarded callback
ERROR: UndefVarError: k not defined

(julia.exe:449068): GModule-CRITICAL **: g_module_symbol: assertion 'symbol != NULL' failed
INFO: Gtk tests passed  

@fcard fcard mentioned this pull request Oct 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants