Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking abs2 #187

Closed
wants to merge 7 commits into from
Closed

breaking abs2 #187

wants to merge 7 commits into from

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Feb 4, 2023

Per #186 (review) and https://github.com/JuliaGraphics/ColorVectorSpace.jl#abs-and-abs2.

Should we also remove

elseif exc.f === abs2 && length(argtypes) == 1
C = argtypes[1]
if C <: MathTypes
print(io, "\nIt is ambiguous whether `abs2(::$C)` should return a real number ")
print(io, "or a color object.")
print(io, "\nYou can use `_abs2(c) = mapreducec(v->float(v)^2, +, 0, c)` ")
print(io, "to get the value compatible with ColorVectorSpace v0.8 or earlier.")
end
end
?

cc @timholy or @johnnychen94.

@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Base: 91.44% // Head: 91.41% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (3aa32a4) compared to base (61e78ec).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   91.44%   91.41%   -0.04%     
==========================================
  Files           3        3              
  Lines         269      268       -1     
==========================================
- Hits          246      245       -1     
  Misses         23       23              
Impacted Files Coverage Δ
src/ColorVectorSpace.jl 90.83% <100.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I'd leave it to @timholy to make the call since releasing this breaking change would require some extra maintenance efforts to bump the versions in downstream packages.

@t-bltg
Copy link
Contributor Author

t-bltg commented Feb 10, 2023

Rebased against master.

@t-bltg
Copy link
Contributor Author

t-bltg commented Feb 22, 2023

@timholy, do you think we can merge this PR and tag a new release ?

@timholy timholy mentioned this pull request Jul 20, 2023
@timholy
Copy link
Member

timholy commented Jul 20, 2023

Sorry for the long delay, see #188

@timholy
Copy link
Member

timholy commented Jul 20, 2023

Folded into #188. Thanks a million, @t-bltg !

@timholy timholy closed this Jul 20, 2023
@t-bltg t-bltg deleted the fut branch July 20, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants