-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump compatibility for FPN/ColorTypes/Colors #129
Conversation
It occurs to me that rolling release has real merits to avoid the version resolving issue until Pkg become smart enough, even if there're only compat commits. |
Since the dependencies related to ColorVectorSpace are somewhat irregular, I have no objection to early merging and tagging this PR. 🚀 |
Does bumping a patch version introduces more humans' attentiveness? No, it solves issues and makes people less headache.
Are there really any compatibility issues in PRs like JuliaImages/ImageShow.jl#19, JuliaImages/ImageCore.jl#124 ? No. Version resolving fails because Pkg doesn't handle the interaction between |
Does your claim above relate to the patch versions? I think we don't need to hesitate to release a patch version of the latest branch. However, note that whether it is a patch version or a minor version is another matter for compatibility, because:
Of course, in "ideal" rolling releases, when such compatibility issues arise, they will be fixed quickly. However, there are clearly not enough developer resources to realize the ideal. My point is that there is no silver bullet. |
😞 🤷♂️ ❤️ |
Is there anything holding this and a release back? It would be great to have for Plots tests. |
I've been pretty busy lately and perceived some unhappiness about this, but there don't seem to be specific objections so let's do it. |
This is a minimal update that gets this working with the latest versions of FixedPointNumbers, ColorTypes, and Colors. I've checked that tests pass without warnings on both ColorTypes 0.9 and ColorTypes 0.10.
Closes #122
Closes #127
Closes #128