Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compatibility for FPN/ColorTypes/Colors #129

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Bump compatibility for FPN/ColorTypes/Colors #129

merged 1 commit into from
Mar 30, 2020

Conversation

timholy
Copy link
Member

@timholy timholy commented Mar 17, 2020

This is a minimal update that gets this working with the latest versions of FixedPointNumbers, ColorTypes, and Colors. I've checked that tests pass without warnings on both ColorTypes 0.9 and ColorTypes 0.10.

Closes #122
Closes #127
Closes #128

@johnnychen94
Copy link
Member

johnnychen94 commented Mar 17, 2020

It occurs to me that rolling release has real merits to avoid the version resolving issue until Pkg become smart enough, even if there're only compat commits.

@kimikage
Copy link
Collaborator

Since the dependencies related to ColorVectorSpace are somewhat irregular, I have no objection to early merging and tagging this PR. 🚀
However, I don't think this is just a matter of the smartness of Pkg. Finding the combinations which work fine, and finding the compatibility issues are ambivalent requirements. Currently, the solution relies on humans' attentiveness, so frequent version changes are not really good.

@johnnychen94
Copy link
Member

johnnychen94 commented Mar 20, 2020

Currently, the solution relies on humans' attentiveness, so frequent version changes are not really good.

Does bumping a patch version introduces more humans' attentiveness? No, it solves issues and makes people less headache.

However, I don't think this is just a matter of the smartness of Pkg.

Are there really any compatibility issues in PRs like JuliaImages/ImageShow.jl#19, JuliaImages/ImageCore.jl#124 ? No. Version resolving fails because Pkg doesn't handle the interaction between [test] and [deps] sections smartly to downgrade Colors, ColorTypes and FixedPointNumbers to a compatible version; there're such versions as declared in Project.toml.

@kimikage
Copy link
Collaborator

Does bumping a patch version introduces more humans' attentiveness?

Does your claim above relate to the patch versions? I think we don't need to hesitate to release a patch version of the latest branch. However, note that whether it is a patch version or a minor version is another matter for compatibility, because:

  1. we are still dealing with many packages in v0 series.
  2. although SemVer guarantees the interface compatibility, it does not guarantee the behavior compatibility (of dependent packages).
  3. we may not strictly follow the SemVer.:sob:

Of course, in "ideal" rolling releases, when such compatibility issues arise, they will be fixed quickly. However, there are clearly not enough developer resources to realize the ideal.

My point is that there is no silver bullet.

@johnnychen94
Copy link
Member

However, there are clearly not enough developer resources to realize the ideal.

😞 🤷‍♂️ ❤️

@daschw
Copy link

daschw commented Mar 29, 2020

Is there anything holding this and a release back? It would be great to have for Plots tests.

@timholy
Copy link
Member Author

timholy commented Mar 30, 2020

I've been pretty busy lately and perceived some unhappiness about this, but there don't seem to be specific objections so let's do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants