Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showsegments support for vizgridfallback! #1056

Merged
merged 9 commits into from
Sep 11, 2024
Merged

Add showsegments support for vizgridfallback! #1056

merged 9 commits into from
Sep 11, 2024

Conversation

eliascarv
Copy link
Member

No description provided.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 54.09836% with 56 lines in your changes missing coverage. Please review.

Project coverage is 87.42%. Comparing base (523d039) to head (c268a01).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ext/geometryset.jl 48.83% 22 Missing ⚠️
ext/grid/cartesian.jl 47.36% 10 Missing ⚠️
ext/grid/rectilinear.jl 0.00% 9 Missing ⚠️
ext/grid/structured.jl 0.00% 8 Missing ⚠️
ext/grid.jl 46.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
- Coverage   87.85%   87.42%   -0.44%     
==========================================
  Files         187      187              
  Lines        5831     5877      +46     
==========================================
+ Hits         5123     5138      +15     
- Misses        708      739      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ext/MeshesMakieExt.jl Outdated Show resolved Hide resolved
@juliohm juliohm merged commit 6624d79 into master Sep 11, 2024
14 of 16 checks passed
@juliohm juliohm deleted the grid-segments branch September 11, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants