-
-
Notifications
You must be signed in to change notification settings - Fork 57
Doc fixes #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc fixes #129
Conversation
|
Lovely :) |
|
Forgot to mention: there are two links in I thought I'd let someone competent add docstrings for these... Also I'm not sure about the mention of |
|
Thanks! I'm really looking forward to this PR being merged! @knuesel
I think the first option is recommended. |
|
Damn totally forgot about this PR! Would be nice to merge it ;) Let me know if I can help with anything! |
Julia 1.6 prints types a bit differently.
The quickstart now lives in docs/src/index.md. The README points to the documentation and will contain additional information for developers.
|
Thanks for the bump @hyrodium . I separated the README and index.md as suggested:
I also updated the doctests and CI config to expect output from Julia 1.6. @SimonDanisch for me this is ready to be merged. |
|
Thanks for the fixes! Nice contribution:tada: |
|
Ah @SimonDanisch one thing you might want to consider: maybe you'd prefer to have See here for the changes I had to make for Julia 1.6. It was quick to do with On the other hand you might prefer to keep the jldoctests to check that things behave as expected? |
This makes the documentation easier to maintain.
|
I went ahead and converted the jldoctests to @SimonDanisch I think we're good? |
|
Cool, thanks a lot! :) |
@replblocks (and add a mention ofGeometryBasics.mesh)doctest()so an error is reported if doctests failFeel free to squash the commits before merging...
Fixes #119, fixes #128