Sg/voronoi #355
Open
Sg/voronoi #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asinghvi17
reviewed
Oct 27, 2025
test/methods/voronoi.jl
Outdated
Comment on lines
61
to
78
| # @testset "Voronoi with custom boundary" begin | ||
| # # Create points inside a square | ||
| # points = [(0.25, 0.25), (0.75, 0.25), (0.75, 0.75), (0.25, 0.75), (0.5, 0.5)] | ||
|
|
||
| # # Create a square boundary | ||
| # boundary = GI.Polygon([ | ||
| # GI.LinearRing([(0.0, 0.0), (1.0, 0.0), (1.0, 1.0), (0.0, 1.0), (0.0, 0.0)]) | ||
| # ]) | ||
|
|
||
| # polygons = GO.voronoi(points, boundary) | ||
| # @test length(polygons) == 5 | ||
|
|
||
| # # All polygons should be valid | ||
| # for poly in polygons | ||
| # @test GI.isgeometry(poly) | ||
| # @test GI.geomtrait(poly) isa GI.PolygonTrait | ||
| # end | ||
| # end |
There was a problem hiding this comment.
Did this test fail? What was the issue here?
There was a problem hiding this comment.
Ah! These were commented out on your branch and I didn't look at them. I will work on that later and update the PR
There was a problem hiding this comment.
Oops! My implementation must not have been working then. I'll try to get it to work with DelaunayTriangulation's api then.
|
Okay I had to add some more advanced clean up for the Thoughts though? Look good to go @asinghvi17? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up and adding in the wrapper of
DelaunyTriangulation'svoronoifunction such that it returnsGeoInterfacepolygons.