Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken checkbounds for CuSparseMatrixCSR and tests #545

Merged
merged 4 commits into from
Nov 14, 2020

Conversation

achuchmala
Copy link
Contributor

Hi,

I fixed the checking bounds for CuSparseMatrixCSR and added tests for CuSparseMatrixCSR and CuSparseMatrixCSC.

@maleadt
Copy link
Member

maleadt commented Nov 13, 2020

Thanks! The CUSPARSE tests belong in test/cusparse.jl though.

@maleadt maleadt added bugfix This gets something working again. cuda array Stuff about CuArray. labels Nov 13, 2020
@achuchmala
Copy link
Contributor Author

Whoops... sorry for that, I didn't notice proper location of tests :/

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #545 (d311b03) into master (e09bf71) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
+ Coverage   77.83%   77.95%   +0.12%     
==========================================
  Files         116      116              
  Lines        6415     6414       -1     
==========================================
+ Hits         4993     5000       +7     
+ Misses       1422     1414       -8     
Impacted Files Coverage Δ
lib/cusparse/array.jl 64.08% <100.00%> (+4.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09bf71...d311b03. Read the comment docs.

@maleadt maleadt merged commit 1139ffd into JuliaGPU:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again. cuda array Stuff about CuArray.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants