Add unit_diag option for sv2! functions #540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ilu02
function returns a matrix composed of a lower triangular and a unit upper triangular factor. I updatedsv2!
to work with unit triangular matrices.Should I use
unit_diag
as an argument with default value false or keep it as a keyword argument?I also found that
istril
has missing methods (JuliaLang/julia#38404), I updated the code to avoid scalar operations.