Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pop!(BinDeps.defaults) back when done #30

Merged
merged 1 commit into from
Apr 5, 2017
Merged

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Apr 5, 2017

No description provided.

@tkelman
Copy link
Contributor Author

tkelman commented Apr 5, 2017

@SimonDanisch since multiple Pkg.build steps run in the same Julia process, should leave things as you found them to avoid influencing other packages

(may want to work on JuliaLang/julia#20070 to avoid this potential issue)

@SimonDanisch
Copy link
Member

Ha, yeah I was just thinking about it not being side effect free for other packages! Thanks! :)

@SimonDanisch SimonDanisch merged commit 3cb5c49 into master Apr 5, 2017
@SimonDanisch SimonDanisch deleted the tk/buildjlclean branch April 5, 2017 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants