Fix test files #11
Merged
Fix test files #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it would be better that each test file is "standalone", so that you can write just `julia test_this.jl` and it works. For that reason, `@testset` should be define outside of test file and we should import all necessary packages in each test file. Also, each file should have license string.
Each test should have its own additional material that is specifically dedicated to that test. This prevents us from linking unit tests together and helps us to understand what material belongs to what test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be better that each test file is "standalone" so that you can write just
julia test_this.jland it works. For that reason,@testsetshould be defined outside of the test file and we should import all necessary packages in each test file. Also, each file should have a license string.Also, we have a kind of bad experience having "data" inside the test folder, because several unit tests are linking together because of common data. Maybe a better idea is to have a folder with the same name than test file and explicitly containing data that is used in that file.