Add language server workspace configuration - #56
Conversation
|
Thank you very much for investigating and coming up with a solution! Just a question as I don't have the Rust toolchain installed and @Pangoraw seems to be busy with other stuff: did you test the change locally? Otherwise, I think it's save to merge it as it is. Do you know if there is a list of available settings? I'd like to expand our README accordingly. |
Pangoraw
left a comment
There was a problem hiding this comment.
LGTM. @piechologist we can setup a rust CI if needed.
|
@rgreminger do you know if it is possible to integrate this schema? so that the settings tab has a nice autocompletion? |
|
@piechologist I compiled and tested the change locally, and works as intended (at least for disabling the missing refs). For a list of examples for the readme, the link of @Pangoraw shows some useful options implemented in VS code, which could be added to the readme (https://github.com/julia-vscode/julia-vscode/blob/8f8d879dc62dee1658115c40dc4e156e9c0cffe4/package.json#L874) @Pangoraw, it would be great to get autocomplete, but I'm not 100% sure it is already possible to include the schema for an extension like this one. Some work on Zed to enable autocompletion for settings of extensions seems to be very recent and ongoing: |
|
Thank you both! Let's merge this now. It's great to get rid of some of the annoying diagnostic messages. I'll add a brief section to the README and make a new release. We can add the autocompletions later when Zed supports it. |
|
Amazing, thanks for reviewing and merging this so quickly. Appreciate the work you're all doing on the extension! |
|
@rgreminger: Our v0.1.9 has just been merged and is now available in Zed (took longer than usual). Works great, thank you for your contribution! Regarding autocompletion, the following PR should have addressed this but there is probably some work to do at our end: |
Hi,
Thanks a lot for all the efforts on the extension!
One of the issues I have is that I am getting many "missing references" from the language server. This is mostly because of issues unrelated with the extension (mainly because of Parameter.jl macros) and I'm getting the same in VS Code. My solution there was to just turn off missing references in the linter as they are mostly just false flags.
I did not manage to to the same here with any settings combination I tried. Finally, I realized that this extension does not forward the settings from Zed to LanguageServer.jl.
This PR fixes this by setting up
language_server_workspace_configuration, which is read by the language server. This follows the exact same approach of the HTML package (https://github.com/zed-industries/zed/blob/main/extensions/html/src/html.rs#L93 ).With the PR, settings like these should be passed along to the language server.