Improve performance of nearby_positions for GridSpaces #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datseris
reviewed
May 10, 2025
Datseris
approved these changes
May 10, 2025
Member
Datseris
left a comment
Datseris
left a comment
There was a problem hiding this comment.
sounds great. every time we add a custom iterator struct to grid space searches we get a bump in performance. That's how this whole business started actually back in v3 I think!
don't forget to bump patch version.
Member
Author
|
we already have the StructVector stuff in the middle of the changes so I think we just need to wait for the release |
Member
Author
|
yes indeed it's actually a bit of a pity we need custom iterators for performance :Q |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit upset by the fact that our game of life at https://juliadynamics.github.io/AgentsExampleZoo.jl/dev/examples/game_of_life_2D_CA/#Conway's-game-of-life allocated, with this allocations disappear completely and the model is 2x faster