-
Notifications
You must be signed in to change notification settings - Fork 500
Change from LunrJs to MinisearchJs for client-side search #2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Something I noticed while testing is that it likes to repeat page headings a lot: The lunr based approach doesn't do that: One other note: the PR has also a lot of non-substantial formatting changes. While I don't disagree with the changes, it's generally a good idea to make the formatting changes independently. In this case, though, it's a little less important -- we're kinda replacing the whole What formatter are you using though? We should probably add a config file and a CI job to format all the JS and CSS at least. There is a suggestion to use eslint: #2072. Separately, we should also apply JuliaFormatter to the Julia code too, but let's cross that bridge a bit later. |
- Updated the UI for the actual search results
|
@mortenpi I have fixed the duplication issue. Additionally, I have updated the search result UI to provide better context for the results like displaying not only title but the matched string(if found) and the category badge too. The new UI looks like this, |
mortenpi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Mostly just a bit of bikeshedding. The main thing would be moving the search layout stuff into a shared SCSS file, to avoid duplication, but then I'd pretty much be happy to merge I think.
|
Alright, will clean up the code as suggested. |
- Cleaned variable names, now they make more sense - Updated CHANGELOG
mortenpi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thank you @Hetarth02! I need to get the Prettier workflow working properly, so I'll hold off on merging until that passes.




This PR aims to close Issue #2141.