Skip to content

fix error in relpath_from_repo_root when file not exists #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2022
Merged

fix error in relpath_from_repo_root when file not exists #1923

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6221bd0
fix error in relpath_from_repo_root when file not exists
clouds56 Sep 7, 2022
2bcd707
Apply suggestions from code review
clouds56 Oct 9, 2022
9e59fa7
update test
clouds56 Oct 9, 2022
ae2bc25
Apply suggestions from code review
clouds56 Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Utilities/Utilities.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,13 +420,15 @@ Returns the path of `file`, relative to the root of the Git repository, or `noth
file is not in a Git repository.
"""
function relpath_from_repo_root(file)
isfile(file) || return nothing
cd(dirname(file)) do
root = repo_root(file)
root !== nothing && startswith(file, root) ? relpath(file, root) : nothing
end
end

function repo_commit(file)
isfile(file) || return nothing
cd(dirname(file)) do
readchomp(`$(git()) rev-parse HEAD`)
end
Expand Down