Support capturing Expr for use in abbreviations.
#133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelHatherly
force-pushed
the
mh/capture-expr
branch
2 times, most recently
from
e5b0d39 to
bd6e571
Compare
MichaelHatherly
force-pushed
the
mh/capture-expr
branch
from
bd6e571 to
a32ab11
Compare
Add a generic interface function `interpolation` that hooks into the stage after macro expansion so that interpolated values in docstrings can implement their own behaviour rather than being directly interpolated into the docstring. Pass the documented expression through to `interpolation` such that abbreviation implementations can make use of this expression for their own needs.
MichaelHatherly
force-pushed
the
mh/capture-expr
branch
from
a32ab11 to
b2746c8
Compare
|
Should be good to go as an initial interface for capturing the expressions, I'll leave leveraging this feature in current abbreviation implementations that could make use of it as separate follow up PRs at some point (unless anyone else gets there before me). @mortenpi feel free to review this one if you find the time to :) |
This was referenced Feb 5, 2023
Open
mortenpi
approved these changes
Feb 5, 2023
Co-authored-by: Morten Piibeleht <[email protected]>
MichaelHatherly
commented
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help handle #54, and possibly make other things easier to handle, such as #19 and other places where digging into the lowered code is a pain while dealing with the raw
Exprwould be more useful.This intercepts documented expressions during macro expansion of
Core.@docand makes the documentedExpravailable for capturing and usage in abbreviation objects.