WIP vector_mode_dual_eval -> vector_mode_dual_eval! #528
Conversation
|
Bump |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
==========================================
+ Coverage 84.83% 84.88% +0.04%
==========================================
Files 9 9
Lines 831 827 -4
==========================================
- Hits 705 702 -3
+ Misses 126 125 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The 1.0 failure seems unrelated |
|
I guess you would kind of think that this modifies |
|
Agreed (though only subject to the "kind of" qualifier... I think anything that mutates any of the arguments should use I'll change it |
src/jacobian.jl
Outdated
|
|
||
| function vector_mode_jacobian(f::F, x, cfg::JacobianConfig{T,V,N}) where {F,T,V,N} | ||
| ydual = vector_mode_dual_eval!(f, x, cfg) | ||
| ydual = vector_mode_dual_eval!(cfg, f, x) |
There was a problem hiding this comment.
even in ! functions I think you put the function first to allow for do syntax. So it would be f, cfg, x.
There was a problem hiding this comment.
You are really trying to make me regret this...
ok I've changed it again
|
Hmm now the failure is on Julia 1, but also seems unrelated to this PR... |
|
Yeah, there is some numerical thing we need to investigate at some point.. |
3 participants
Still need to change elsewhere, this is just a reminder to rename
vector_mode_dual_evalto make it clear it mutates its inputs (was confusing when debugging).