Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loosen restriction on input array for cache type assertion #142

Merged
merged 3 commits into from
Aug 23, 2016

Conversation

jrevels
Copy link
Member

@jrevels jrevels commented Aug 23, 2016

This fixes an accidental regression in our support of non-Array ForwardDiff inputs (thanks for pointing this out, @tkelman).

I'm a tad concerned that this might damage performance for non-AbstractArray inputs, since the fallback here uses the result of ndims in a type parameter.

It would be nice if there were something like similar_type we could call on array-likes, which would allow us to generalize the array types used by the cache types.

@tkelman
Copy link
Contributor

tkelman commented Aug 23, 2016

thank pkgeval, and keep an eye on the pulse page the day after you tag

@jrevels jrevels merged commit 8177416 into master Aug 23, 2016
@jrevels jrevels deleted the jr/cachefix branch August 23, 2016 20:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants