Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added inline annotations #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gasagna
Copy link
Contributor

@gasagna gasagna commented Sep 10, 2017

I have noticed consistent and significant speed ups (about 1.5x) in a largish private package by adding inline annotations to methods for +, -, /, * for dual numbers.

I have sprinkled @inline annotation around in other parts of the module to catch other use cases, but it might be too much.

@mlubin
Copy link
Contributor

mlubin commented Sep 12, 2017

@gasagna, ForwardDiff already incorporates improvements like this and has additional speedups over DualNumbers thanks to chunking (https://arxiv.org/abs/1607.07892).

@gasagna
Copy link
Contributor Author

gasagna commented Sep 12, 2017

Thanks. Any chance this will be merged or you reckon it is best to move to ForwardDiff as a dependency for my package?

@mlubin
Copy link
Contributor

mlubin commented Sep 12, 2017

I'm willing to provide commit access if you (or somebody else) would like to take on some maintenance responsibility.

@gasagna
Copy link
Contributor Author

gasagna commented Sep 14, 2017

Thanks, but I am not sure I want to step up as maintainer of this package :)

@KristofferC
Copy link
Collaborator

FWIW, 0.7 should make this PR not needed since the inlining heuristics are greatly improved. However, that doesn't help 0.6 so...

@dkarrasch
Copy link

I guess this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants