Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less clever sum rrule for the default case #493

Closed
wants to merge 1 commit into from
Closed

Less clever sum rrule for the default case #493

wants to merge 1 commit into from

Commits on Aug 2, 2021

  1. Less clever sum rrule for the default case 

    The sum rrule relies on broadcasting to figure out the
result shape of the cotangent. However, this has two
disadvantages:

1. We need to keep the original array around
2. Broadcasting machinery is complicated and tough on (higher-order) AD

This adds a special case for `dims=:`, which simply stores
the dimensions of the original array and uses `fill`
in the pullback, which has a simple rrule and is thus
much easier to AD.
    @Keno
    Keno committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    2d72b50 View commit details
    Browse the repository at this point in the history