Return the correct number of cotangents for functions with optional arguments #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Jun 4, 2021
src/rulesets/LinearAlgebra/dense.jl
Outdated
Comment on lines
202
to
204
| function pinv_pullback(Δy) | ||
| return full_pb(Δy)[1:2] | ||
| end |
Member
There was a problem hiding this comment.
I am trying to remeber if there is a reason we don't do this:
Suggested change
| function pinv_pullback(Δy) | |
| return full_pb(Δy)[1:2] | |
| end | |
| pinv_pullback(Δy) = full_pb(Δy)[1:2] |
oxinabox
approved these changes
Jun 4, 2021
Member
Author
|
It looks like inference works on Julia 1.6 and 1.5, but does not work on 1.3 (I didn't check 1.4). Are we ok with that? |
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 98.38% 98.39%
=======================================
Files 21 21
Lines 1984 1989 +5
=======================================
+ Hits 1952 1957 +5
Misses 32 32
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaDiff/ChainRulesTestUtils.jl#168 (merged, and then reverted) introduced checks that the number of cotangents from the rrule is correct.
Possible fix for JuliaDiff/ChainRulesTestUtils.jl#168 (comment)