Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More like #28 #72

Merged
merged 2 commits into from
Feb 26, 2019
Merged

More like #28 #72

merged 2 commits into from
Feb 26, 2019

Conversation

timholy
Copy link
Member

@timholy timholy commented Feb 26, 2019

I missed a couple of ccalls to memcpy in #68 (more issue #28).

@timholy timholy mentioned this pull request Feb 26, 2019
@timholy
Copy link
Member Author

timholy commented Feb 26, 2019

This seems to fix the remaining ☠️ in Julia's tests (I've not run them all together, but they work individually).

Also note this throws in a convenience method for writing the results of the juliatests to an arbitrary file.

@codecov-io
Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #72   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           8      8           
  Lines        1262   1266    +4     
=====================================
- Misses       1262   1266    +4
Impacted Files Coverage Δ
src/JuliaInterpreter.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b78715...3ab4639. Read the comment docs.

@timholy timholy merged commit 2c8ca6e into master Feb 26, 2019
@timholy timholy deleted the teh/more_28 branch February 26, 2019 15:40
@timholy timholy mentioned this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants