use copy instead of copy_codeinfo #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Talk about simultaneous! |
KristofferC
commented
Feb 26, 2019
src/precompile.jl
Outdated
| @@ -33,7 +33,6 @@ function _precompile_() | |||
| precompile(Tuple{typeof(extract_args), Module, Expr}) | |||
| precompile(Tuple{typeof(enter_call), Int, Int}) | |||
| precompile(Tuple{typeof(enter_call_expr), Expr}) | |||
| precompile(Tuple{typeof(copy_codeinfo), Core.CodeInfo}) | |||
There was a problem hiding this comment.
I don't think this is needed
> @time precompile(Tuple{typeof(copy), Core.CodeInfo})
0.000011 seconds (9 allocations: 448 bytes)
|
Looks like this only exists in 1.1. Unfortunate. |
KristofferC
force-pushed
the
kc/copyinfo
branch
2 times, most recently
from
8c18500
to
5d39133
Compare
KristofferC
force-pushed
the
kc/copyinfo
branch
from
5d39133
to
de37b1a
Compare
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 8 8
Lines 1260 1262 +2
=====================================
- Misses 1260 1262 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62