Merged
Conversation
ianatol
force-pushed
the
ia/semiconc
branch
7 times, most recently
from
ae21149 to
6aae120
Compare
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
- Coverage 38.16% 37.54% -0.62%
==========================================
Files 10 10
Lines 993 1012 +19
==========================================
+ Hits 379 380 +1
- Misses 614 632 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
@aviatesk can you review and merge, since this is now on master? |
Member
|
I'm working on this. A general request: please make sure to add test cases when submitting a PR with a certain amount of changes/new features like this. Currently this PR yields an obvious |
aviatesk
reviewed
Sep 5, 2022
src/Cthulhu.jl
Outdated
| (; src, rt, infos, slottypes, codeinf, effects) = lookup_constproped(interp, curs, override, optimize) | ||
| else | ||
| if optimize | ||
| if isa(override, SemiConcreteCallInfo) |
Member
There was a problem hiding this comment.
We should lift this branch up, since otherwise the lookup call later will override the IR.
src/callsite.jl
Outdated
| # XXX: The first argument could be const-overriden too | ||
| name = get_mi(ci).def.name | ||
| tt = ci.argtypes[2:end] | ||
| __show_limited(limiter, name, tt, get_rt(ci)) |
aviatesk
force-pushed
the
ia/semiconc
branch
from
6aae120 to
f6d2a9c
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #280