Store effects in OptimizationSource

[ianatol]

@Keno pointed out to me that https://github.com/JuliaDebug/Cthulhu.jl/blob/master/src/Cthulhu.jl#L343 was broken. To fix, we want to store effects in OptimizationSource and access them from there instead of the current, faulty way.

[codecov-commenter]

Codecov Report

Merging #281 (019f6d5) into master (00415a4) will increase coverage by 0.42%.
The diff coverage is 76.92%.

❗ Current head 019f6d5 differs from pull request most recent head 9d86941. Consider uploading reports for the commit 9d86941 to get more accurate results

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   56.23%   56.65%   +0.42%     
==========================================
  Files           7        7              
  Lines        1115     1112       -3     
==========================================
+ Hits          627      630       +3     
+ Misses        488      482       -6     

Impacted Files	Coverage Δ
src/Cthulhu.jl	36.66% <0.00%> (ø)
src/interpreter.jl	92.15% <83.33%> (-4.14%)	⬇️
src/codeview.jl	62.50% <0.00%> (+6.25%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00415a4...9d86941. Read the comment docs.

[ianatol]

Should be good to go now that JuliaLang/julia#44777 is merged

Edit: More importantly, Cthulhu is broken on master now that JuliaLang/julia#44777 is merged

[simeonschaub]

Does that PR need to be backported? Otherwise, Cthulhu would be broken on 1.8, right?

[ianatol]

Hmm yeah, we would want to backport it for that effects printing to properly work on 1.8. It would also be a bit cleaner to just check EFFECTS_ENABLED rather than the version number.

[ianatol]

Rebased with #285