Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates with the incoming type lattice overhaul #238

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aviatesk
Copy link
Member

This might not be the cleanest implementation, but on this branch Cthulhu should work with JuliaLang/julia#42596.
I opened this PR as a draft for those who may want to work on the overhaul.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021

Codecov Report

Merging #238 (675a16b) into master (af1a2fc) will decrease coverage by 1.27%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   82.85%   81.58%   -1.28%     
==========================================
  Files           7        7              
  Lines        1021     1037      +16     
==========================================
  Hits          846      846              
- Misses        175      191      +16     
Impacted Files Coverage Δ
src/reflection.jl 85.10% <0.00%> (ø)
src/Cthulhu.jl 68.79% <15.00%> (-3.83%) ⬇️
src/codeview.jl 92.14% <50.00%> (-1.34%) ⬇️
src/callsite.jl 78.50% <100.00%> (ø)
src/interpreter.jl 92.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af1a2fc...675a16b. Read the comment docs.

@aviatesk aviatesk force-pushed the avi/typelattice branch 5 times, most recently from 7599fa8 to 023b1c6 Compare October 16, 2021 17:43
@aviatesk aviatesk force-pushed the avi/typelattice branch 2 times, most recently from 15016c9 to fedcb34 Compare November 11, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants