Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for query with strict keyword #328

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

testercwt
Copy link

kwargs in DBInterface will transform to params, therefore strict will be always false in SQLite 1.6.0

kwargs in DBInterface will transform to params
@metab0t
Copy link
Collaborator

metab0t commented Mar 4, 2023

Keywords in definition of DBInterface.execute in SQLite is shadowed by keyword argument version in DBInterface and they are packed with SQL parameters as a whole.

https://github.com/JuliaDatabases/DBInterface.jl/blob/85891482dfc5cd2c6c7c40adaf96ad813c9f0a6d/src/DBInterface.jl#L151

So I think we should remove allowduplicates::Bool = false, strict::Bool = false in function definition as well, but it feels a little strange because we extract two special names from SQL parameters.
What is your opinion @quinnj?

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (3e576b9) to head (77a6f4a).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   93.60%   93.63%   +0.03%     
==========================================
  Files           4        4              
  Lines         563      566       +3     
==========================================
+ Hits          527      530       +3     
  Misses         36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinnj
Copy link
Member

quinnj commented Mar 11, 2023

Yeah, I don't love having to extra the keyword args from the params; let me try to think of an alternative solution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants