Fixed some warnings #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 22, 2016 11:34
|
This is going to need more detailed attention in order to keep compatibility with 0.4 |
|
It's a bit of a mess - the last 2 commits were about switching back to bytestring() as unsafe_string() would make the tests to fail (it's not a straightforward replacement). 420272a and 2c4ac45 are all right. I can tweak them a bit, to keep them working in v0.4. I'm thinking by adding version detection and type / function aliases? Or if you have other ideas, let me know, happy to help. |
|
Version detection with aliases sounds like the right way forward to me :) |
|
All right, I'll give it a go 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a series of deprecation warnings in Julia 0.5