Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing interface element #336

Merged
merged 1 commit into from
Apr 14, 2022
Merged

missing interface element #336

merged 1 commit into from
Apr 14, 2022

Conversation

lawless-m
Copy link
Contributor

@lawless-m lawless-m commented Mar 15, 2022

getconnection is missing, which is part of the DBInterface

used by executemany, missing in ODBC

see open issue on DBInterface

JuliaDatabases/DBInterface.jl#43

@lawless-m lawless-m changed the title misssing interface element missing interface element Mar 15, 2022
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lawless-m! Sorry for the slow review here!

@quinnj
Copy link
Member

quinnj commented Apr 14, 2022

Hmmmm.....the test failures look suspicious, but I don't see how this PR would have changed anything related to query results suddenly starting to fail. I'll merge for now, but will make a note to investigate what's going on there.

@quinnj quinnj merged commit e078321 into JuliaDatabases:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants