Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add execute(f, stmt) method #35

Merged
merged 1 commit into from
Jan 26, 2021
Merged

add execute(f, stmt) method #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/DBInterface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ const StatementParams = Union{PositionalStatementParams, NamedStatementParams}
DBInterface.execute(conn::DBInterface.Connection, sql::AbstractString, [params]) => DBInterface.Cursor
DBInterface.execute(stmt::DBInterface.Statement, [params]) => DBInterface.Cursor
DBInterface.execute(f::Callable, conn::DBInterface.Connection, sql::AbstractString, [params])
DBInterface.execute(f::Callable, stmt::DBInterface.Statement, [params])

Database packages should overload `DBInterface.execute` for a valid, prepared `DBInterface.Statement` subtype (the first method
signature is defined in DBInterface.jl using `DBInterface.prepare`), which takes an optional `params` argument, which should be
Expand All @@ -118,11 +119,19 @@ function execute end

execute(conn::Connection, sql::AbstractString, params) = execute(prepare(conn, sql), params)

function execute(f::Base.Callable, stmt::Statement, params)
cursor = execute(stmt, params)
try
return f(cursor)
finally
close!(cursor)
end
end

function execute(f::Base.Callable, conn::Connection, sql::AbstractString, params)
stmt = prepare(conn, sql)
try
cursor = execute(stmt, params)
return f(cursor)
return execute(f, stmt, params)
finally
close!(stmt)
end
Expand All @@ -132,6 +141,7 @@ end
execute(stmt::Statement; kwargs...) = execute(stmt, kwargs.data)
execute(conn::Connection, sql::AbstractString; kwargs...) = execute(conn, sql, kwargs.data)
execute(f::Base.Callable, conn::Connection, sql::AbstractString; kwargs...) = execute(f, conn, sql, kwargs.data)
execute(f::Base.Callable, stmt::Statement; kwargs...) = execute(f, stmt, kwargs.data)

struct LazyIndex{T} <: AbstractVector{Any}
x::T
Expand Down