-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ByRow #293
Conversation
@quinnj I have also made some small clean-up proposals to src/namedtuples.jl - I hope they are correct 😄. |
Codecov ReportBase: 95.08% // Head: 95.05% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
- Coverage 95.08% 95.05% -0.04%
==========================================
Files 7 7
Lines 692 708 +16
==========================================
+ Hits 658 673 +15
- Misses 34 35 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Milan Bouchet-Valat <[email protected]>
@quinnj and @pdeffebach - can you please check and approve as this is a surprisingly complex PR (fortunately not big) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the slow review, but this LGTM. I left one comment on an example doc + doc package prefix.
Co-authored-by: Jacob Quinn <[email protected]>
Fixed. The |
Following the discussion in #287.
CC @quinnj @nalimilan @pdeffebach