Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ByRow #293

Merged
merged 8 commits into from
Sep 16, 2022
Merged

add ByRow #293

merged 8 commits into from
Sep 16, 2022

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Sep 7, 2022

Following the discussion in #287.

CC @quinnj @nalimilan @pdeffebach

@bkamins
Copy link
Member Author

bkamins commented Sep 7, 2022

@quinnj I have also made some small clean-up proposals to src/namedtuples.jl - I hope they are correct 😄.

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Base: 95.08% // Head: 95.05% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (ffcbd1b) compared to base (2d97b73).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
- Coverage   95.08%   95.05%   -0.04%     
==========================================
  Files           7        7              
  Lines         692      708      +16     
==========================================
+ Hits          658      673      +15     
- Misses         34       35       +1     
Impacted Files Coverage Δ
src/Tables.jl 88.30% <ø> (-0.32%) ⬇️
src/namedtuples.jl 100.00% <100.00%> (ø)
src/utils.jl 90.58% <100.00%> (+1.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/utils.jl Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
Co-authored-by: Milan Bouchet-Valat <[email protected]>
src/utils.jl Show resolved Hide resolved
@bkamins
Copy link
Member Author

bkamins commented Sep 10, 2022

@quinnj and @pdeffebach - can you please check and approve as this is a surprisingly complex PR (fortunately not big)

src/utils.jl Show resolved Hide resolved
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review, but this LGTM. I left one comment on an example doc + doc package prefix.

@bkamins
Copy link
Member Author

bkamins commented Sep 16, 2022

Fixed. The Tables. prefix for sure should be there. I had DataFrames.jl loaded, which exports it so I forgotten to add it in the docstring.

@quinnj quinnj merged commit 16262f8 into main Sep 16, 2022
@quinnj quinnj deleted the bk/ByRow branch September 16, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants