Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add consistency checks in iterate #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add consistency checks in iterate #43

wants to merge 1 commit into from

Conversation

mbauman
Copy link
Collaborator

@mbauman mbauman commented Dec 11, 2024 •
edited
Loading

  • ensure that iterate generates length(I) values
  • ensure that iterate always matches all of its skips against an index in the axis

addresses the most egregious bad behaviors in #7 and #31. They still don't work as you might hope, but now they throw errors rather than selecting a potentially wrong index.

@mbauman
add consistency checks in iterate
f1730ba 
* ensure that iterate generates `length(I)` values
* ensure that iterate always makes it to the end of all skips

addresses the most egregious bad behaviors in #7 and #31
@mbauman
Copy link
Collaborator Author

mbauman commented Dec 12, 2024

I think this is a good thing to do, whether we add in additional scalar to_indices calls (#41) or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mbauman