vcat collect type #944
Merged
vcat collect type #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Though in light of JuliaLang/julia#16029, I think it would be even better to do |
gustafsson
force-pushed
the
vcat-type-collect
branch
from
88d46d4
to
5296ff8
Compare
added 2 commits
August 26, 2016 14:16
Just using [a...] creates an infinitely recursive loop
gustafsson
force-pushed
the
vcat-type-collect
branch
from
5296ff8
to
ffcedd3
Compare
|
@nalimilan Any comment on this? The test added (and fixed) in this PR currently fails on master. |
|
Looks good. Could you add a comment before the test referring to this PR and explaining what is being tested? |
|
Thanks! |
GordStephen
pushed a commit
to GordStephen/DataFrames.jl
that referenced
this pull request
Sep 13, 2016
collect() doesn't recognize the common type if the arguments are of mixed types.
maximerischard
pushed a commit
to maximerischard/DataFrames.jl
that referenced
this pull request
Sep 28, 2016
collect() doesn't recognize the common type if the arguments are of mixed types.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collect doesn't recognize the common type if the arguments are of mixed types