(Mostly) Bug Fixes for writing Strings #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main thing here is fixing some string write bugs (places where
length
should've beenncodeunits
).There's a few other minor things such as:
Char
.'\0'
instead of' '
. I think this is the "correct" way but now I can't actually find the resource I used that said this. I'm fine to either keep or drop this change..dbf
file in the test directory. Instead we write a DataFrame to dbf so that we know right away what the data is supposed to look like.DBFTables.write(path::String, table)
now returns thepath
instead of bytes written.