Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed recode to accept more general collection types #290

Merged
merged 8 commits into from
Apr 4, 2021

Conversation

HenricoWitvliet
Copy link
Contributor

The first element in a Pair for recoding can now be anything that
behaves like a collection and supports in.

Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you run some benchmarks to check that performance doesn't regress?

src/recode.jl Outdated Show resolved Hide resolved
src/recode.jl Outdated Show resolved Hide resolved
src/recode.jl Outdated Show resolved Hide resolved
test/16_recode.jl Outdated Show resolved Hide resolved
test/16_recode.jl Outdated Show resolved Hide resolved
test/16_recode.jl Outdated Show resolved Hide resolved
src/recode.jl Outdated Show resolved Hide resolved
src/recode.jl Outdated Show resolved Hide resolved
src/recode.jl Show resolved Hide resolved
src/recode.jl Outdated Show resolved Hide resolved
HenricoWitvliet and others added 8 commits April 4, 2021 15:32
The first element in a Pair for recoding can now be anything that
behaves like a collection and supports `in`.
Co-authored-by: Milan Bouchet-Valat <[email protected]>
Co-authored-by: Milan Bouchet-Valat <[email protected]>
Co-authored-by: Milan Bouchet-Valat <[email protected]>
@nalimilan nalimilan merged commit 220198a into JuliaData:master Apr 4, 2021
@nalimilan
Copy link
Member

Sorry for the delay!

@HenricoWitvliet HenricoWitvliet deleted the recode branch July 31, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants