Add simple renames - WIP #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressing [list from NEWS.md](#20 (comment)).
Keno
reviewed
Jun 13, 2018
| @@ -394,6 +394,34 @@ const renames = [ | |||
| @add_rename iteratoreltype IteratorEltype v"0.7.0-DEV.3309" | |||
| @add_rename nb_available bytesavailable v"0.7.0-DEV.3477" | |||
| @add_rename broadcast_indices broadcast_axes v"0.7.0-DEV.4936" | |||
| @add_rename Base.Test Test v"0.7.0-alpha" | |||
There was a problem hiding this comment.
OK, I will see why it didn't trigger on the depoexercism.jl FC PRs.
Keno
reviewed
Jun 13, 2018
| @add_rename Random.dSFMT Random.DSFMT v"0.7.0-alpha" | ||
| @add_rename gc GC.gc v"0.7.0-alpha" | ||
| @add_rename gc_enable GC.enable v"0.7.0-alpha" | ||
| @add_rename Base.@gc_preserve GC.@preserve v"0.7.0-alpha" |
There was a problem hiding this comment.
This doesn't work. This check looks for identifiers.
Keno
reviewed
Jun 13, 2018
| @add_rename Base.@gc_preserve GC.@preserve v"0.7.0-alpha" | ||
| @add_rename LinSpace LinRange v"0.7.0-alpha" | ||
| @add_rename endof lastindex v"0.7.0-alpha" | ||
| @add_rename DateTime() DateTime(1) v"0.7.0-alpha" |
There was a problem hiding this comment.
Same here, this is not an identifier. You can write a custom AST matcher instead.
Keno
reviewed
Jun 13, 2018
| @add_rename linearindices LinearIndices v"0.7.0-alpha" | ||
| @add_rename LinAlg.fillslots! LinearAlgebra.fillstored! v"0.7.0-alpha" | ||
| @add_rename cfunction @cfunction v"0.7.0-alpha" | ||
| @add_rename GMP.gmp_version GMP.version v"0.7.0-alpha" |
There was a problem hiding this comment.
This needs support for renames in other modules, which this doesn't provide. Remove these for now.
Keno
requested changes
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing list from NEWS.md.