Skip to content

Conversation

@mofeing
Copy link
Collaborator

@mofeing mofeing commented Jun 13, 2025

As discussed in #30, this PR removes composition for the time being as the behavior of the current implementation is not well-defined and adds little value.

It can be readded in a future minor version.

@mofeing mofeing added this to the 1.0 milestone Jun 13, 2025
@mofeing mofeing requested a review from goerz June 13, 2025 13:01
@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.89%. Comparing base (33984fb) to head (be9bb17).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   87.05%   85.89%   -1.17%     
==========================================
  Files           2        1       -1     
  Lines          85       78       -7     
==========================================
- Hits           74       67       -7     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@goerz goerz force-pushed the remove-composition branch from d5c046f to be9bb17 Compare June 13, 2025 14:55
@goerz goerz merged commit 82159af into master Jun 13, 2025
7 of 8 checks passed
@goerz goerz deleted the remove-composition branch June 13, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants