[re-land] Use -Werror (with some exceptions) on Windows builds
#496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@DilumAluthge Anything else needed to merge here? |
We're not ready to enable `-Werror` comprehensively on Windows, but this will include most warnings and prevent us from accidentally adding new failures.
DilumAluthge
changed the title
-Werror (with some exceptions) on Windows builds-Werror (with some exceptions) on Windows builds
DilumAluthge
force-pushed
the
ct/windows-Werror2
branch
from
cb3e77b to
36e88db
Compare
Member
|
CI seems unhappy for some reason - I'm trying to figure out why. |
DilumAluthge
approved these changes
Nov 4, 2025
Member
DilumAluthge
left a comment
DilumAluthge
left a comment
There was a problem hiding this comment.
Alright, let's give this a second try.
DilumAluthge
added
the
automerge
Member
|
@topolarity Do you want this backported to Julia 1.13? |
Contributor
Author
|
Sure! I don't see why not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-land #484 (as requested in #487 (comment))
This will need the treehashes to be signed again.