Skip to content

Revert "Use -Werror (with exceptions) on Windows builds" #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2025
Merged

Revert "Use -Werror (with exceptions) on Windows builds" #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified pipelines/main/launch_signed_jobs.yml.signature
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion pipelines/main/launch_upload_jobs.yml.signature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Salted__,X�^�VPQ���z-�ʓa4O/���N#pU��T)��"�����ۑ�To�A�ָ��0u�}����󙏉�S�ik�=!�qF
Salted__�[�r��e��tžb�3�3n_ n�`��B�3>��q��#�ͻiˈpJ�pnG��81�j[�OKuE�o5����`פ��X� �
6 changes: 3 additions & 3 deletions pipelines/main/platforms/build_windows.arches
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# OS TRIPLET ARCH DOCKER_ARCH MAKE_FLAGS TIMEOUT DOCKER_TAG
windows x86_64-w64-mingw32 x86_64 x86_64 VERBOSE=1,JL_CFLAGS="-Werror -Wno-error=array-bounds -Wno-error=array-bounds= -Wno-error=infinite-recursion",JL_CXXFLAGS="-Werror -Wno-error=array-bounds -Wno-error=array-bounds= -Wno-error=infinite-recursion" . v7.10
windows i686-w64-mingw32 x86_64 i686 VERBOSE=1,JL_CFLAGS="-Werror -Wno-error=array-bounds -Wno-error=array-bounds= -Wno-error=infinite-recursion",JL_CXXFLAGS="-Werror -Wno-error=array-bounds -Wno-error=array-bounds= -Wno-error=infinite-recursion" . v7.10
# OS TRIPLET ARCH DOCKER_ARCH MAKE_FLAGS TIMEOUT DOCKER_TAG
windows x86_64-w64-mingw32 x86_64 x86_64 VERBOSE=1 . v7.10
windows i686-w64-mingw32 x86_64 i686 VERBOSE=1 . v7.10

# These special lines allow us to embed default values for the columns above.
# Any column without a default mapping here will simply substitute a `.` to the empty string
Expand Down
Binary file modified pipelines/scheduled/coverage/coverage.yml.signature
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion pipelines/scheduled/launch_signed_jobs.yml.signature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Salted__g1����{�%۷���|����9�ḿp�Y~8�Kķ���nZ��J�΁K��UUG�8����Il=2LJ/}~i|i��8�Ь��/�U�N�
Salted__gs���z��~�5W�R$>��A��T����W�[�7�M.��g���۳I�>�վ���2eaqln-�+Mo�'��>�M��G3#�
3 changes: 2 additions & 1 deletion pipelines/scheduled/launch_upload_jobs.yml.signature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Salted__tX���pd�w�V�}-[������EQȢ.! �8$Ib�������!A,��+'�L);;��q����u&�E�dS�j�𦯲��Z�Q�
Salted___�
�J�gJx�Mދj�Va���A��_�|��'�Uk�R�'-s��F��0D ���X".���z�co2h�c���9��٬�C�2�g�(l
Expand Down
10 changes: 2 additions & 8 deletions utilities/arches_env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ fi

enforce_sanitized() {
for value in "$@"; do
if ! [[ "${value}" =~ ^[a-zA-Z0-9_\.\"+[:space:]=,-]*$ ]]; then
if ! [[ "${value}" =~ ^[a-zA-Z0-9_\.[:space:]=,-]*$ ]]; then
echo "Arches file '${ARCHES_FILE}' contains value '${value}' with non-alphanumeric characters; refusing to parse!" >&2
exit 1
fi
Expand Down Expand Up @@ -54,13 +54,7 @@ while read -r line; do
enforce_sanitized "${line}"

# Convert line to array
{
set -f
# shellcheck disable=SC2207
# `read -a` ignores quoted strings when splitting and we are controlling word
# splitting via IFS and `set -f` as ShellCheck recommends
IFS=$'\n' line_array=( $(xargs -n1 <<<"${line}") )
}
readarray -d ' ' -t line_array <<<"${line}"

# Panic if we don't have the same number of items as our column names:
if [[ "${#line_array[@]}" != "${#var_names[@]}" ]]; then
Expand Down