Switch windows codesigning over to Azure Trusted Signing #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
added
the
DROP COMMITS BEFORE MERGING
|
Converting to draft just to make sure we don't accidentally merge before we drop the "drop me" commits. |
staticfloat
force-pushed
the
sf/azure_signing
branch
4 times, most recently
from
f00a061 to
c82f549
Compare
|
Looks like it's working, dropping the "DROP ME" commits, we can merge when this goes green. |
staticfloat
force-pushed
the
sf/azure_signing
branch
2 times, most recently
from
a243481 to
f1bc618
Compare
staticfloat
removed
the
DROP COMMITS BEFORE MERGING
staticfloat
force-pushed
the
sf/azure_signing
branch
from
f1bc618 to
adddeaa
Compare
This is the new blessed way of codesigning on windows
staticfloat
force-pushed
the
sf/azure_signing
branch
from
adddeaa to
285213b
Compare
|
@staticfloat CI is green now. Is this ready to merge? cc: @davidanthoff |
|
Let's give this a try. We can revert (or make a follow-up fix PR) if needed. |
|
No point in reverting, even if this doesn't work: the old thing also won't work anymore because that certificate is expired :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.