make upload job concurrent with lldb job #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
commented
Jun 21, 2024
vtjnash
commented
Jun 21, 2024
staticfloat
force-pushed
the
jn/concurrent-upload
branch
from
4161cfd
to
88f39b7
Compare
staticfloat
requested changes
Jun 25, 2024
vtjnash
commented
Aug 17, 2024
| @@ -32,22 +41,12 @@ if [[ "${#CORE_DUMPS[@]}" > 0 ]]; then | |||
| (sleep "${DEBUGGER_TIMEOUT}"; kill "${DBG_PID}" 2>/dev/null >/dev/null; echo "DEBUGGER KILLED BY WATCHDOG TIMER") & | |||
|
|
|||
| # Wait for one debugging command to finish before starting the next | |||
| wait "${DBG_PID}" || true | |||
| wait -f "${DBG_PID}" || true | |||
| done | |||
There was a problem hiding this comment.
If this async printing isn't reliable enough for you, we could also pipe this through dd like so:
Suggested change
| done | |
| done | dd bs=64k status=none |
such that all of the content printed here gets buffered via dd up to to the specified chunk size (64k) to make it atomic (and the same for each upload upon success of it as well)
|
good enough for me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.