Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip UnitfulRecipes #263

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Skip UnitfulRecipes #263

merged 1 commit into from
Apr 16, 2024

Conversation

giordano
Copy link
Contributor

This is an old and unmaintained package (jw3126/UnitfulRecipes.jl#81), so even if we had to fix anything in that package, nothing could be done about it. Note: this is currently failing tests in JuliaLang/julia#53891 (comment) because it's trying to install a very ancient version of GR.jl, I don't see any fix possible if the package is deprecated.

This is an old and unmaintained package (jw3126/UnitfulRecipes.jl#81), so even if we had to fix anything in that package, nothing could be done about it.  Note: this is currently failing tests in JuliaLang/julia#53891 (comment) because it's trying to install a very ancient version of `GR.jl`, I don't see any fix possible if the package is deprecated.
@giordano giordano requested a review from maleadt April 15, 2024 23:46
@maleadt maleadt merged commit 7b85fa9 into master Apr 16, 2024
6 checks passed
@maleadt maleadt deleted the mg/skip-UnitfulRecipes branch April 16, 2024 04:59
@PallHaraldsson
Copy link

"doesn't even work on Julia v1.9" but assuming it did on 1.0+ then it should still work? I'm ok with this since deprecated, just thinking if excluding should really be needed...

@giordano
Copy link
Contributor Author

but assuming it did on 1.0+ then it should still work?

[email protected] doesn't work for me on any Julia 1.9+ on aarch64-apple-darwin, and the problem is that UnitfulRecipes is deprecated and incompatible with recent versions of Plots (and hence GR.jl), so we can't possibly get more recent versions of GR.jl. Besides the GR.jl problem, the fact is that even if we solved this problem through registry gymnastics, if we later find other bugs in UnitfulRecipes we can't fix them because it's unmaintained, so what's the point of testing it to start with?

@PallHaraldsson
Copy link

I'm ok with not testing (what this PR is about, PkgEval). I'm just a bit concerned why software supporting 1.0+, with dependencies (e.g. GR) all supporting 1.0+, stop working. It's not a huge priority to find out and explain... I just can see people installing and failing, and thinking Julia to blame (correctly?) and thinking PkgEval should have caught (it did...!).

If this is only on aarch64-apple-darwin I would understand (is PkgEval (also) testing there?). [Please don't waste time to get a later version to work on current Julia, because it wouldn't show older working anyway, what ideally should happen.]

@t-bltg
Copy link
Contributor

t-bltg commented Apr 25, 2024

and the problem is that UnitfulRecipes is deprecated and incompatible with recent versions of Plots

It's just that UnitfulRecipes is now integrated and maintained in Plots.jl as a package extension.

@giordano
Copy link
Contributor Author

It's just that UnitfulRecipes is now integrated and maintained in Plots.jl as a package extension.

Yes, but what matters is that UnitfulRecipes itself isn't going to be touched, so testing it, finding errors and not being able to do anything about it isn't useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants