Add Revise's dependencies to "important packages" #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to me. Shall we add some comments in the TOML file, to clarify why those packages are included in the list? |
Co-authored-by: Dilum Aluthge <[email protected]>
Co-authored-by: Dilum Aluthge <[email protected]>
maleadt
force-pushed
the
teh/add_Revise_deps
branch
from
09ae37c
to
3071308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia 1.10 was released while still breaking CodeTracking (due to a parser change, JuliaLang/JuliaSyntax.jl#316 (comment)). I was deliberately not fixing this issue assuming it would be noticed and investigated during the 1.10 PkgEval runs, but it seems to have either been decided to be unimportant or simply not noticed. EDIT: LoweredCodeUtils tests are broken, too.
While this is not actually a big deal, given that these packages both underlie Revise and extensively test internals, perhaps it makes sense to ensure they don't get blacklisted.