Reexport std and var from Statistics
#336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved `maximum` to immediately after `minimum`. This makes it easier to match-up the outputs against what `BenchmarkTools` prints.
milesfrain
changed the title
std and varstd and var from Statistics
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #146 (part 2)
The original request was to just add a note in the docs about reexports from
Statistics: #146 (comment)But then I found we were missing some re-exports that the docs assume exist. So I added those back in as originally proposed in the above issue.
This PR also removes unnecessary
Statisticsimports in the tests. FYI @maleadt, This reverts your change from #294 to restore my change from #149.If we don't want to go with the reexport strategy, that's also fine with me. I just want things to be consistent.