Prepare SparseFEM benchmark to changes to find() on Julia master #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
force-pushed
the
nl/linearindices
branch
from
220b80f
to
d7ab4d7
Compare
|
Julia 0.6 needs JuliaLang/Compat.jl#446 to work. |
|
Can you bump the Compat version in REQUIRE to 0.44.0? |
find() will soon return cartesian indices, so this benchmark needs to convert them to linear indices. Unfortunately, LinearIndice currently does not allow indexing with an array, so we need to use a comprehension.
nalimilan
force-pushed
the
nl/linearindices
branch
from
d7ab4d7
to
f9a553b
Compare
ararslan
approved these changes
Jan 9, 2018
|
@ararslan Thanks! Can you merge? Doesn't look like I have the needed rights. |
|
Yep, I was waiting for CI to finish, but it turns out I just needed to refresh the page. :) I'll retune the benchmarks then trigger Nanosoldier on your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findwill soon return cartesian indices (JuliaLang/julia#24774), so this benchmark needs to convert them to linear indices. Unfortunately,LinearIndicescurrently does not allow indexing with an array, so we need to usemap.