Add find benchmarks #147
Merged
Add find benchmarks #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a separate file since more benchmarks should be added for other methods, and on various types.
ararslan
reviewed
Dec 6, 2017
| @@ -292,7 +292,7 @@ for x in (x_range, x_vec, Int16.(x_range), Float64.(x_range), Float32.(x_range)) | |||
|
|
|||
| g["==", string(typeof(x_vec), " == ", typeof(x))] = | |||
| @benchmarkable $x_vec == $x | |||
| g["isequal", string(typeof(x_vec), " isequa l", typeof(x))] = | |||
| g["isequal", string(typeof(x_vec), " isequal ", typeof(x))] = | |||
There was a problem hiding this comment.
My own mistake...
|
Seems reasonable to me, but what do I know? Any idea who would be best to review this? |
|
I guess @timholy's +1 is already a good validation. |
|
Works for me. |
Keno
pushed a commit
that referenced
this pull request
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a separate file since more benchmarks should be added for other
methods, and on various types.
Will be useful to assess the impact of JuliaLang/julia#24774.