Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try standardising coverage #14

Open
wants to merge 4 commits into
base: version-1
Choose a base branch
from
Open

try standardising coverage #14

wants to merge 4 commits into from

Conversation

simonbyrne
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 10, 2018

Codecov Report

Merging #14 into version-1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           version-1    #14   +/-   ##
========================================
  Coverage        100%   100%           
========================================
  Files              1      1           
  Lines              1      1           
========================================
  Hits               1      1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1200c9e...97a1ab6. Read the comment docs.

@christopher-dG
Copy link
Member

Is this working now? I actually forked and made this change myself just now before seeing this PR... 🙃
Also I agree with changing the Coveralls repo token environment variable name, I was also going to make that PR but wasn't sure if a breaking change would be welcome.
I'd love to have this in soon to make my life a bit easier for PkgTemplates!

@simonbyrne
Copy link
Member Author

simonbyrne commented Sep 24, 2018

Well, I'm sort of waiting on JuliaCI/Coverage.jl#174

Unfortunately the tests are broken on Coverage.jl (yes, I appreciate the irony), but I don't understand how it works, and i'm not game to pull the trigger on it in case I start breaking everyone's CI builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants