Azlcpo wrapper #28
Merged
Azlcpo wrapper #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helgee
reviewed
Jul 8, 2024
src/a.jl
Outdated
|
|
||
| ### Arguments ### | ||
|
|
||
| - `method`: Method to obtain the surface normal vector. The only choice currently supported is `"ELLIPSOID"` |
There was a problem hiding this comment.
To have a more "julian" API it would make sense to make the method, azccw, and elplsz parameters optional keyword argument.
There was a problem hiding this comment.
Sure, I can do this. For consistency, I would put azccw and elplsz as optional keyword arguments also in azlrec, recazl, drdazl and dazldr.
|
Great, thanks! |
|
You are welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented wrapper for
azlcpofunction.