Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test run CI without coverage #838

Closed
wants to merge 1 commit into from
Closed

Test run CI without coverage #838

wants to merge 1 commit into from

Conversation

fredrikekre
Copy link
Member

Just testing this out, it should be significantly faster (see e.g. julia-actions/julia-runtest#19 (comment)). I think it should be sufficient to produce and submit coverage from one or two workers, I don't think there is any OS specific code-paths in StaticArrays for example.

@mateuszbaran
Copy link
Collaborator

Why does this PR have coverage checks but other recent PRs don't?

@fredrikekre
Copy link
Member Author

Doesn't seem seem as bad on CI as I see locally (3+ times overhead):

│ Row │ os      │ version  │ overhead │
│     │ Symbol  │ Version… │ Float64  │
├─────┼─────────┼──────────┼──────────┤
│ 1   │ linux   │ v"1.0.0" │ 1.08609  │
│ 2   │ linux   │ v"1.1.0" │ 1.23864  │
│ 3   │ linux   │ v"1.2.0" │ 1.62651  │
│ 4   │ linux   │ v"1.3.0" │ 1.88571  │
│ 5   │ linux   │ v"1.4.0" │ 2.19565  │
│ 6   │ linux   │ v"1.6.0" │ 1.60976  │
│ 7   │ macOS   │ v"1.0.0" │ 0.957143 │
│ 8   │ macOS   │ v"1.4.0" │ 2.04545  │
│ 9   │ macOS   │ v"1.6.0" │ 1.42857  │
│ 10  │ windows │ v"1.0.0" │ 1.2963   │
│ 11  │ windows │ v"1.4.0" │ 1.96226  │
│ 12  │ windows │ v"1.6.0" │ 1.69767  │

│ Row │ os      │ overhead │
│     │ Symbol  │ Float64  │
├─────┼─────────┼──────────┤
│ 1   │ linux   │ 1.60706  │
│ 2   │ macOS   │ 1.47706  │
│ 3   │ windows │ 1.65208  │

│ Row │ version  │ overhead │
│     │ Version… │ Float64  │
├─────┼──────────┼──────────┤
│ 1   │ v"1.0.0" │ 1.11318  │
│ 2   │ v"1.1.0" │ 1.23864  │
│ 3   │ v"1.2.0" │ 1.62651  │
│ 4   │ v"1.3.0" │ 1.88571  │
│ 5   │ v"1.4.0" │ 2.06779  │
│ 6   │ v"1.6.0" │ 1.57867  │

@KristofferC
Copy link
Contributor

Is CI really running on all versions except the latest released one (the most important)? :P

@c42f
Copy link
Member

c42f commented Oct 18, 2020

Is CI really running on all versions except the latest released one (the most important)? :P

Apparently 🤦

@c42f c42f mentioned this pull request Oct 18, 2020
@fredrikekre fredrikekre closed this May 3, 2021
@fredrikekre fredrikekre deleted the fe/coverage branch May 3, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants