Make MArray stay mutable #536
Conversation
src/abstractarray.jl
Outdated
| @@ -78,8 +78,8 @@ similar_type(::Type{A},::Type{T},s::Size{S}) where {A<:AbstractArray,T,S} = defa | |||
| default_similar_type(::Type{T}, s::Size{S}, ::Type{Val{D}}) where {T,S,D} = SArray{Tuple{S...},T,D,prod(s)} | |||
|
|
|||
|
|
|||
| # should mutable things stay mutable? | |||
| #similar_type{SA<:Union{MVector,MMatrix,MArray},T,S}(::Type{SA},::Type{T},s::Size{S}) = mutable_similar_type(T,s,length_val(s)) | |||
| # should mutable things stay mutable? yes | |||
There was a problem hiding this comment.
maybe just delete the comment :)
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
+ Coverage 66.11% 66.12% +0.01%
==========================================
Files 38 38
Lines 2892 2893 +1
==========================================
+ Hits 1912 1913 +1
Misses 980 980
Continue to review full report at Codecov.
|
|
So... are we going ahead with this? |
|
Yes :). |
|
Yes yes yes 😆 |
|
:) And - welcome, Chris! |
|
This will need a breaking release... we're probably not v1.0 yet though. |
|
Yup, but minor releases when pre-1.0 are allowed to be breaking in semvar? |
|
Yes! |
|
Oh I read what you meant wrong. I thought you meant this would have to wait until StaticArrays v1.0. |
|
Right. That was actually a clumsy attempt to get you to use your new powers and create a release for me ;) |
Ref: #327